[jira] [Resolved] (CLK-601) TextField sets size when not appropriate

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

[jira] [Resolved] (CLK-601) TextField sets size when not appropriate

JIRA jira@apache.org

     [ https://issues.apache.org/jira/browse/CLK-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adrian A. resolved CLK-601.

    Resolution: Fixed

Fixed in Branch click-3.0.0

> TextField sets size when not appropriate
> ----------------------------------------
>                 Key: CLK-601
>                 URL: https://issues.apache.org/jira/browse/CLK-601
>             Project: Click
>          Issue Type: Improvement
>          Components: core
>    Affects Versions: 2.1.0 RC1
>            Reporter: WarnerJan Veldhuis
>            Assignee: Adrian A.
>            Priority: Trivial
>             Fix For: 3.0.0
> In the TextField class, the size attribute is *always* rendered regardless of the value of size. Since the size-attribute should be optional for the input-tag, it should be conditional, just as it is the case with maxLength and tabIndex. This would also mean that the default of 20 should be dropped.
> current code:
> buffer.appendAttribute("size", getSize());
> proposed code:
> if ( getSize() > 0 ) {
>    buffer.appendAttribute("size", getSize());
> }
> Since the HTML-spec says size is implied, it should only be added if there is any size.

This message was sent by Atlassian JIRA